Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for AWS SSO profile in config #19

Merged
merged 7 commits into from
Dec 8, 2024
Merged

feat: add support for AWS SSO profile in config #19

merged 7 commits into from
Dec 8, 2024

Conversation

narenaryan
Copy link
Collaborator

@narenaryan narenaryan commented Dec 8, 2024

Description

This PR adds support for AWS SSO profiles. Just set the below key in Whispr config:

vault: aws
sso_profile: dev

Where dev is the SSO profile name used to sign into AWS.

Changes

  • Add AWS SSO Profile support
  • Improve Whispr CLI commands help messages
  • Add a clean_build script for local package build and test

@narenaryan narenaryan added the enhancement New feature or request label Dec 8, 2024
@narenaryan narenaryan self-assigned this Dec 8, 2024
@coveralls
Copy link

coveralls commented Dec 8, 2024

Pull Request Test Coverage Report for Build 12223745179

Details

  • 9 of 11 (81.82%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+8.4%) to 78.992%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/whispr/about.py 0 1 0.0%
src/whispr/cli.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/whispr/cli.py 1 0.0%
Totals Coverage Status
Change from base Build 11875375064: 8.4%
Covered Lines: 188
Relevant Lines: 238

💛 - Coveralls

@narenaryan narenaryan merged commit 6e1e432 into main Dec 8, 2024
2 checks passed
@narenaryan narenaryan deleted the feat/1 branch December 8, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants