Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve get method phpdoc in EntityProviderInterface #474

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

msmakouz
Copy link
Member

What was changed

Improved PHPDoc to avoid error in PHPStan. Example:

https://phpstan.org/r/551dad36-e7e8-4c2a-a6be-4e24aaf98411

Closes: #439

@msmakouz msmakouz self-assigned this Mar 29, 2024
@msmakouz msmakouz requested a review from roxblnfk March 29, 2024 14:22
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (9ce5e6f) to head (625bc8e).

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #474   +/-   ##
=========================================
  Coverage     91.50%   91.50%           
  Complexity     1814     1814           
=========================================
  Files           115      115           
  Lines          4600     4600           
=========================================
  Hits           4209     4209           
  Misses          391      391           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz msmakouz merged commit 107de86 into 2.x Mar 29, 2024
42 checks passed
@msmakouz msmakouz deleted the phpdoc branch March 29, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Possible incorrect phpDoc in EntityProviderInterface
2 participants