Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.4 #501

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Support PHP 8.4 #501

merged 6 commits into from
Dec 12, 2024

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Dec 10, 2024

🔍 What was changed

  • Used Spiral Code Style
  • Fixed PHP 8.4 deprecations
  • Used common Cycle CI workflows

Related issue: cycle/database#213

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 90.24793% with 59 lines in your changes missing coverage. Please review.

Project coverage is 91.59%. Comparing base (e42905c) to head (a6f46a3).
Report is 7 commits behind head on 2.x.

Files with missing lines Patch % Lines
src/Schema.php 61.53% 10 Missing ⚠️
src/ORM.php 70.58% 5 Missing ⚠️
src/Collection/DoctrineCollectionFactory.php 40.00% 3 Missing ⚠️
src/Collection/IlluminateCollectionFactory.php 25.00% 3 Missing ⚠️
src/Command/Traits/ErrorTrait.php 0.00% 3 Missing ⚠️
src/Select/AbstractLoader.php 85.00% 3 Missing ⚠️
src/Transaction/Pool.php 81.25% 3 Missing ⚠️
src/Collection/LoophpCollectionFactory.php 33.33% 2 Missing ⚠️
src/Command/Database/Update.php 50.00% 2 Missing ⚠️
src/Command/Special/MergeCommand.php 0.00% 2 Missing ⚠️
... and 19 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #501      +/-   ##
============================================
+ Coverage     91.52%   91.59%   +0.07%     
+ Complexity     1817     1814       -3     
============================================
  Files           115      115              
  Lines          4615     4642      +27     
============================================
+ Hits           4224     4252      +28     
+ Misses          391      390       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit 9703d14 into 2.x Dec 12, 2024
26 of 28 checks passed
@roxblnfk roxblnfk deleted the spiral-code-style branch December 12, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant