symfony sms connector configuration fix

cyklokoalicia · Jun 1, 2024 · 9425713 · 9425713
1 parent 16f8cbf
commit 9425713
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 21 deletions.
diff --git a/src/SmsConnector/AbstractConnector.php b/src/SmsConnector/AbstractConnector.php
@@ -36,7 +36,7 @@ public function __construct(
         $debugMode = false
     ) {
         $this->debugMode = $debugMode;
-        $connectorConfig = json_decode($configuration->get('connectors')['config'] ?? '[]', true)[static::getType()] ?? [];
+        $connectorConfig = json_decode($configuration->get('connectors')['config'][static::getType()] ?? '[]', true) ?? [];
         $this->checkConfig($connectorConfig);
     }
 

diff --git a/tests/SmsConnector/EuroSmsConnectorTest.php b/tests/SmsConnector/EuroSmsConnectorTest.php
@@ -20,15 +20,15 @@ public function testCheckConfig()
             ->with('connectors')
             ->willReturn(
                 [
-                    'config' => json_encode(
-                        [
-                            'eurosms' => [
+                    'config' => [
+                        'eurosms' => json_encode(
+                            [
                                 'gatewayId' => 'Id',
                                 'gatewayKey' => 'Key',
                                 'gatewaySenderNumber' => 'SenderNumber',
                             ]
-                        ]
-                    )
+                        )
+                    ]
                 ]
             );
         $smsConnector = new EuroSmsConnector(
@@ -69,15 +69,15 @@ public function testCheckConfigError(
             ->with('connectors')
             ->willReturn(
                 [
-                    'config' => json_encode(
-                        [
-                            'eurosms' => [
+                    'config' => [
+                        'eurosms' => json_encode(
+                            [
                                 'gatewayId' => $gatewayId,
                                 'gatewayKey' => $gatewayKey,
                                 'gatewaySenderNumber' => $gatewaySenderNumber,
                             ]
-                        ]
-                    )
+                        )
+                    ]
                 ]
             );
         $smsConnector = new EuroSmsConnector(
@@ -115,15 +115,15 @@ public function testRespond()
             ->with('connectors')
             ->willReturn(
                 [
-                    'config' => json_encode(
-                        [
-                            'eurosms' => [
+                    'config' => [
+                        'eurosms' => json_encode(
+                            [
                                 'gatewayId' => 'Id',
                                 'gatewayKey' => 'Key',
                                 'gatewaySenderNumber' => 'SenderNumber',
                             ]
-                        ]
-                    )
+                        )
+                    ]
                 ]
             );
         $smsConnector = new EuroSmsConnector(
@@ -149,15 +149,15 @@ public function testSend()
             ->with('connectors')
             ->willReturn(
                 [
-                    'config' => json_encode(
-                        [
-                            'eurosms' => [
+                    'config' => [
+                        'eurosms' => json_encode(
+                            [
                                 'gatewayId' => 'Id',
                                 'gatewayKey' => 'Key',
                                 'gatewaySenderNumber' => 'SenderNumber',
                             ]
-                        ]
-                    )
+                        )
+                    ]
                 ]
             );
         $smsConnector = new EuroSmsConnector(