Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc hub: document multi-user config post jupyter server v2 upgrade #625

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

oliver-sanders
Copy link
Member

  • Auto-spawning of other user's servers can now be configured.
  • Jupyter Server security policy must be defined if Jupyter Lab or any other server extension is included in the deployment.
  • Simplify some sections and expand on the new configurations.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

src/conf.py Outdated Show resolved Hide resolved
src/reference/architecture/ui-server.rst Outdated Show resolved Hide resolved
src/user-guide/sharing-access-to-workflows.rst Outdated Show resolved Hide resolved
src/user-guide/sharing-access-to-workflows.rst Outdated Show resolved Hide resolved
src/user-guide/sharing-access-to-workflows.rst Outdated Show resolved Hide resolved
src/user-guide/sharing-access-to-workflows.rst Outdated Show resolved Hide resolved
src/user-guide/sharing-access-to-workflows.rst Outdated Show resolved Hide resolved
src/user-guide/sharing-access-to-workflows.rst Outdated Show resolved Hide resolved
src/user-guide/sharing-access-to-workflows.rst Outdated Show resolved Hide resolved
src/user-guide/sharing-access-to-workflows.rst Outdated Show resolved Hide resolved
@MetRonnie
Copy link
Member

Exception during build worked around by #636 (though build still fails on that PR without the changes from this one I think)

@oliver-sanders
Copy link
Member Author

(rebased)

@oliver-sanders
Copy link
Member Author

(rebased)

@oliver-sanders
Copy link
Member Author

CI is failing with:

Exception occurred:
  File "/opt/hostedtoolcache/Python/3.9.17/x64/lib/python3.9/site-packages/hieroglyph/builder.py", line 135, in post_process_images
    if node['uri'].startswith(self.outdir):

This error is coming from make slides and is caused by a lack of Sphinx 7 support in hieroglyph. Basically we jumped the gun with Sphinx 7 but the tests didn't appear to fail at the time?

@MetRonnie
Copy link
Member

Basically we jumped the gun with Sphinx 7 but the tests didn't appear to fail at the time?

I think the problem is we're peeling back the lid on multiple failures but only one at a time. Unfortunately I didn't think to test the slides locally

@oliver-sanders
Copy link
Member Author

I've removed slides from the standard list of CI builds, with #640 to track re-adding this when hieroglyph is fixed.

The alternative would be to revert recent Sphinx 7 fixes and roll back to Sphinx 6. Given we're not actively using the slides I think we may as well drop them for now.

@oliver-sanders oliver-sanders changed the base branch from master to 8.2.x August 31, 2023 14:44
@oliver-sanders
Copy link
Member Author

Sphinx version has now been rolled back to <7 for 8.2.x (still >7.1 for 8.3.x)

@MetRonnie
Copy link
Member

Need this to work in Sphinx <7.2 (which Tim spotted in cylc/cylc-flow#5710)

diff --git a/src/user-guide/task-implementation/job-scripts.rst b/src/user-guide/task-implementation/job-scripts.rst
index a6d74a26..a5ba61d8 100644
--- a/src/user-guide/task-implementation/job-scripts.rst
+++ b/src/user-guide/task-implementation/job-scripts.rst
@@ -186,5 +186,5 @@ Task messages are validated by:
 
 .. autoclass:: cylc.flow.unicode_rules.TaskMessageValidator
-   :no-index:
+   :noindex:
 
 Aborting Job Scripts on Error

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Sep 11, 2023

Does that need to be cherry-picked back?

cylc/cylc-flow#5710 (comment)

@oliver-sanders
Copy link
Member Author

Merged 8.2.x PR and kicked CI here.

oliver-sanders and others added 3 commits September 12, 2023 13:38
* Auto-spawning of other user's servers can now be configured.
* Jupyter Server security policy must be defined if Jupyter Lab
  or any other server extension is included in the deployment.
* Simplify some sections and expand on the new configurations.
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@oliver-sanders
Copy link
Member Author

🤞 should pass this time...

@MetRonnie MetRonnie mentioned this pull request Sep 12, 2023
1 task
@oliver-sanders oliver-sanders merged commit 3ec14d0 into cylc:8.2.x Sep 12, 2023
@oliver-sanders oliver-sanders deleted the jupyter-server-2 branch September 12, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants