Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cheat sheet entry on rose date -> isodatetime #670

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

MetRonnie
Copy link
Member

Paired with cylc/cylc-flow#5838

image

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

@MetRonnie MetRonnie added content Addition or modification of documentation small labels Nov 21, 2023
@MetRonnie MetRonnie added this to the 8.2.x milestone Nov 21, 2023
@MetRonnie MetRonnie requested a review from wxtim November 21, 2023 17:47
@MetRonnie MetRonnie self-assigned this Nov 21, 2023
@MetRonnie
Copy link
Member Author

MetRonnie commented Nov 21, 2023

Tests failing in same way on master - fixed by cylc/cylc-flow#5718

rose date -c
- ::

isodatetime ref

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment : I like the syntax synopsis as you have defined it in the linter with the square brackets as this makes it clearer that the ref is replacing the -c, i.e.

rose date [-c] => isodatetime [ref]

@MetRonnie MetRonnie requested review from oliver-sanders and removed request for wxtim November 22, 2023 12:41
@MetRonnie MetRonnie marked this pull request as ready for review November 22, 2023 12:49
@MetRonnie
Copy link
Member Author

Slightly changed for clarity:

image

@ukmo-ccbunney: Just a comment : I like the syntax synopsis as you have defined it in the linter with the square brackets as this makes it clearer that the ref is replacing the -c, i.e.

rose date [-c] => isodatetime [ref]

This was done for brevity as the -c/ref is optional. Here, I think it's fairly clear with how the rows line up?

@ukmo-ccbunney
Copy link

Looks perfect @MetRonnie .

@MetRonnie MetRonnie merged commit 49d5365 into cylc:8.2.x Nov 23, 2023
1 check failed
@MetRonnie MetRonnie deleted the rose-date branch November 23, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Addition or modification of documentation small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants