-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintain order for CYLC_PYTHONPATH #5853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
requested changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the test please
wxtim
force-pushed
the
maintain_user_order
branch
from
November 30, 2023 13:21
7f52873
to
4a3bb32
Compare
MetRonnie
reviewed
Nov 30, 2023
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
reviewed
Nov 30, 2023
MetRonnie
approved these changes
Nov 30, 2023
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Dec 5, 2023
…at_runtime * upstream/master: tui: avoid deprecated import (cylc#5858) Exclude broken pytest-asyncio version remove lint (cylc#5856) Async pipe decorator: preserve wrapped func signature Maintain order for CYLC_PYTHONPATH (cylc#5853) Update tests/integration/tui/conftest.py tests/i: fix flaky tui/test_updater tests (cylc#5849) tests/i: tui - attempt to stabilise tests Bump pypa/gh-action-pypi-publish from 1.8.10 to 1.8.11 (cylc#5851) tests/i: fix flaky tui/test_updater tests Improve changelog entries Fix bad TOML example in `cylc lint` docstring (cylc#5843) lint - S011 no longer warns against 0{{a}} (cylc#5841) `cylc lint`: add rule to catch `rose date` tui: show view tui: log view tui: tidy dangling interfaces tui: fix an obscure freezing issue tui: update screenshots Tui 1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port this review observation back into Cylc.
Follow-up to #5727