Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintain order for CYLC_PYTHONPATH #5853

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Nov 30, 2023

Port this review observation back into Cylc.

Follow-up to #5727

@wxtim wxtim requested a review from MetRonnie November 30, 2023 10:56
@wxtim wxtim self-assigned this Nov 30, 2023
@wxtim wxtim added this to the cylc-8.3.0 milestone Nov 30, 2023
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the test please

@wxtim wxtim force-pushed the maintain_user_order branch from 7f52873 to 4a3bb32 Compare November 30, 2023 13:21
@wxtim wxtim requested a review from MetRonnie November 30, 2023 13:21
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim wxtim requested a review from MetRonnie November 30, 2023 15:37
@MetRonnie MetRonnie merged commit da365bf into cylc:master Nov 30, 2023
0 of 24 checks passed
wxtim added a commit to wxtim/cylc that referenced this pull request Dec 5, 2023
…at_runtime

* upstream/master:
  tui: avoid deprecated import (cylc#5858)
  Exclude broken pytest-asyncio version
  remove lint (cylc#5856)
  Async pipe decorator: preserve wrapped func signature
  Maintain order for CYLC_PYTHONPATH (cylc#5853)
  Update tests/integration/tui/conftest.py
  tests/i: fix flaky tui/test_updater tests (cylc#5849)
  tests/i: tui - attempt to stabilise tests
  Bump pypa/gh-action-pypi-publish from 1.8.10 to 1.8.11 (cylc#5851)
  tests/i: fix flaky tui/test_updater tests
  Improve changelog entries
  Fix bad TOML example in `cylc lint` docstring (cylc#5843)
  lint - S011 no longer warns against 0{{a}} (cylc#5841)
  `cylc lint`: add rule to catch `rose date`
  tui: show view
  tui: log view
  tui: tidy dangling interfaces
  tui: fix an obscure freezing issue
  tui: update screenshots
  Tui 1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants