-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't protect static assets from XSRF #592
Conversation
JupyterHub 4.1 applies XSRF checks on authenticated GET requests by default
@oliver-sanders I think this should be on 1.4.5 milestone? |
(we will probs skip 1.4.5 since we are near ready for 1.5.0 release but we can merge it through as normal) |
I added one more commit based on jupyterhub/jupyterhub#4800 (comment) to ensure the xsrf cookie is set on |
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Tested with JupyterHub 4.1.5 and 4.0.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, happy removing xsrf checks for static resources, tested with JupyterHub 4.1.5, couldn't force a page load error. Many thanks!
JupyterHub 4.1 applies XSRF checks to authenticated GET requests, which is not necessary for static assets. It would be a valid alternative to not authenticate these requests.
This solves the static asset request, described in jupyterhub/jupyterhub#4800
The userprofile request must be addressed in https://github.com/cylc/cylc-ui
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.