Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined behaviour #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix undefined behaviour #25

wants to merge 2 commits into from

Conversation

DelilahHoare
Copy link

Fixes #23.

@DelilahHoare
Ensure functions always return a value
f0157d8 
This prevents compiler warnings and segfaults when compiled with
recent GCC.
@DelilahHoare
Add a zero terminator to key_table
7817f5c 
processevent() expects this.  This prevents the game from hanging
on input when compiled with recent Clang.
ljn0099
ljn0099 approved these changes Dec 18, 2022
View reviewed changes
Copy link

@ljn0099 ljn0099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helped me to run the game.

ljn0099 added a commit to ljn0099/ASCIIpOrtal that referenced this pull request Dec 18, 2022
@ljn0099
Added Fix undefined behaviour cymonsgames#25 pull request of the fork
9c08a12
@gissf1 gissf1 mentioned this pull request Apr 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljn0099 ljn0099 ljn0099 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

segfault at startup
2 participants
@DelilahHoare @ljn0099