Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add other download badges #797

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from
Open

Add other download badges #797

wants to merge 4 commits into from

Conversation

jermanuts
Copy link

@jermanuts jermanuts commented Mar 8, 2024 •
edited
Loading

the App store badge looks a bit off. Can you guys scale it? thanks.

@jermanuts
Copy link
Author

or guess no need to scale lol
image

sneurlax
sneurlax previously approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@sneurlax sneurlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Adds an App Store badge to the README.md, no other changes. Merge it!

@sneurlax
Copy link
Member

sneurlax commented Mar 8, 2024 •
edited
Loading

Oh, the only minor issue with this is it's to main. We usually merge to staging then main. But these are nontechnical/documentation-only changes, so that's OK.

For future reference, if you are outside of the Cipher Stack organization, your PR test will always fail. So it's better to open a PR from some branch on your remote to some non-main and non-staging branch on ours and have one of us open the PR from that new bridge to staging--then tests will run with access to the secrets needed for certain features.

@jermanuts
Copy link
Author

jermanuts commented Mar 8, 2024 •
edited
Loading

Can you look at #798, I couldn't fork Duo repo and accidently sent PR to this repo.

And add the App store badge for it too https://apps.apple.com/us/app/stack-duo-by-cypher-stack/id6446602017 and their F-Droid.

@danrmiller danrmiller changed the base branch from main to staging May 9, 2024 04:09
@danrmiller danrmiller dismissed sneurlax’s stale review May 9, 2024 04:09

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneurlax sneurlax sneurlax left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jermanuts @sneurlax @rehrar