feat(other): add Junk button when Junk folder is configured for an IMAP Server #1420
+69
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baraka24
force-pushed
the
add-junk-button-to-msg_controls
branch
from
a4eb244 to
976228d
Compare
Baraka24
changed the title
Baraka24
force-pushed
the
add-junk-button-to-msg_controls
branch
4 times, most recently
from
6aa2823 to
4c80273
Compare
christer77
force-pushed
the
add-junk-button-to-msg_controls
branch
5 times, most recently
from
d913a2b to
a403d24
Compare
christer77
force-pushed
the
add-junk-button-to-msg_controls
branch
from
a403d24 to
128fe01
Compare
kroky
reviewed
Jan 7, 2025
| } | ||
| } | ||
| } else { | ||
| if (!$mailbox->message_action($folder_name, mb_strtoupper($action_type), $uids)['status']) { |
There was a problem hiding this comment.
You have to check what happens in mailbox down the road - besides IMAP, it is passing this method to EWS if that's the account type and I am not sure EWS understands the Junk action unless you code it...
kroky
reviewed
Jan 7, 2025
| @@ -1205,6 +1151,53 @@ public function process() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private function perform_action($mailbox, $action_type, $uids, $folder, $specials, $server_details) { | |||
There was a problem hiding this comment.
I think this method changes the behavior of the old code in imap_message_action... e.g. original_folder_setting was only used for archive operations, now you use it for all special folder types of operations (e.g. delete). If you refactor this code please make sure you don't introduce regressions or unintentional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Issues