-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create group #5
Create group #5
Conversation
3fb0874
to
789169b
Compare
Few ideas on how to extend this one:
|
So, this recent commit should take care of it. There is now an option to specify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that having at least one test would be really nice but apart from the tiny suggestions this is in a very good shape. Thanks!
All of the comments were helpful and made sense to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot! Merging in the current state, tests can come in later PRs.
No description provided.