SPSH-1514 User Externaldata #867
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improve Logging in Permissions decorator * test coverage for permissions.decorator
* use found LDAPGroupName instead of constructed when adding person * fix lint
* exclude removed PKs in EmailEventHandler.handlePersonenkontextUpdatedEvent * recude cognitive complexity of EmailEventHandler.handlePerson
* Truncate names
* add guard, uem-password for self * add test * refactor * fix test * clean up test * use username over referrer * fix test
* Keycloak-Backend-URL is now hard coded because it should be the same for all DEV-Branches now * Changed Deployment to tag * KC-Base-URL wrong spec * Set to official deployment tag
DPDS93CT
approved these changes
Jan 13, 2025
| @ApiProperty({ type: [UserExeternalDataResponseOpshPk] }) | ||
| public personenkontexte: UserExeternalDataResponseOpshPk[]; | ||
|
|
||
| @ApiProperty() |
There was a problem hiding this comment.
zusätzlich mit nullable: true kennzeichnen?
| @ApiProperty() | ||
| public id: string; | ||
|
|
||
| public constructor(username: string, oxContext: string) { |
There was a problem hiding this comment.
für die Konsistenz hier vielleicht oxUsername, hier kann man auch die FlavoredTypes benutzen
| @@ -87,12 +90,17 @@ describe('PersonenkontextRepo', () => { | |||
|
|
|||
| await em.persistAndFlush(newPerson); | |||
|
|
|||
| const organisation1: Organisation<true> = await organisationRepo.save( | |||
There was a problem hiding this comment.
Ich glaube organisation ohne 1 passt auch :D
kristoff-kiefer
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/SPSH-1514
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review