fix chunked upload #430
Merged
fix chunked upload #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solverat
force-pushed
the
feature/chunk
branch
from
d6408ef
to
5521ae6
Compare
solverat
force-pushed
the
feature/chunk
branch
from
5521ae6
to
6c5b561
Compare
|
@life-style-de, nice! I just tested your PR with a larger file and it works flawless! Thank you very much! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assuming this commit/PR introduced the problem:
07ba2c3
#374
the chunk handling was changed from getting the chunks by path+index to uuid based retrieval.
$this->formBuilderChunkStorage->listContents($uuid)already returns a full list of all chunks and the outer loop iterating additionally over all parts is not needed anymore. leading to all chunks being concatenated to the temp file$totalPartstimes. this results in a broken file that isoriginal_size * chunk_countin size.