Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Try to fix proxy issue #24

Merged
merged 1 commit into from
Aug 25, 2024
Merged

fix: Try to fix proxy issue #24

merged 1 commit into from
Aug 25, 2024

Conversation

dadav
Copy link
Owner

@dadav dadav commented Aug 24, 2024

Somehow the usage of []byte triggered some strange problem described in #20.

So this should resolve #20...

Tested with @johnwarburton 's script, no more errors with this.

@dadav dadav marked this pull request as ready for review August 24, 2024 18:55
@johnwarburton
Copy link
Contributor

Hi @dadav

Thanks for looking into this.

I can confirm - no more errors. I ran a number of edge cases and could not get the test system to give any errors. Also no race conditions were logged when running the code

The only time I had any issues was when I had 1500 servers hammer the test server in a massive DDoS and worked until it ran out of TCP connections :-)

I can give this branch a big +1 and once again, massive thanks to you for gorge and for looking into this weird bug

Regards

John

@dadav
Copy link
Owner Author

dadav commented Aug 25, 2024

Hi @dadav

Thanks for looking into this.

I can confirm - no more errors. I ran a number of edge cases and could not get the test system to give any errors. Also no race conditions were logged when running the code

The only time I had any issues was when I had 1500 servers hammer the test server in a massive DDoS and worked until it ran out of TCP connections :-)

I can give this branch a big +1 and once again, massive thanks to you for gorge and for looking into this weird bug

Regards

John

Awesome! As always, thanks for reporting and testing. I wish I could explain exactly why this happened. I will probably spend some time analyzing this more. But for now I'm happy this is fixed :)

@dadav dadav merged commit 1560926 into main Aug 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

caching errors on clean hosts (reprise?)
2 participants