Improve cache and fallback-proxy behaviour for /v3/release #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly _do_ fallback
…urable via 'usual' means)
… with a 404, return 'empty' 200 result if fallback-proxy is not enabled
…ters apply before offset, despite documentation implying otherwise
|
Hi @Egari , |
I've been meaning to re-build and test it, but haven't gotten around to it yet. |
|
Merged via #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case; caching with fallback to puppet forge.
stampede cache-key now takes request path and/or full request URI into account (incl query parameters)
Note: query parameters is semi-important to cache responses for /v3/releases queries as done by
puppet module install.Before this patch, with caching enabled, you could see puppetlabs-stdlib responses when requesting
/v3/releases?module=puppetlabs-logrotateif puppetlabs-stdlib was the first to be queried.show basic "proxied requests" stats in the UI
if fallback-proxy is enabled, and
/v3/releasesis requested, requests are now redirected to the proxy sooner to be more consistent in responses returned and prevent empty responses.