Test worker priorization #45
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,195 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/dadosjusbr/alba/storage" | ||
| "github.com/dadosjusbr/executor" | ||
| "github.com/matryer/is" | ||
| ) | ||
|
|
||
| var pipelinesDB = []storage.Pipeline{ | ||
|
There was a problem hiding this comment. Tu deve precisar criar vários desses a medida que o teste aumenta. Sugestão: cria os Daí, cria o |
||
| { | ||
| Pipeline: executor.Pipeline{ | ||
| Name: "Pipeline 01: Finalizado com sucesso", | ||
| }, | ||
| ID: "pipeline1", | ||
| Entity: "Pipeline 01", | ||
| City: "João Pessoa", | ||
| FU: "PB", | ||
| Repo: "github.com/dadosjusbr/coletores", | ||
| Frequency: 30, | ||
| StartDay: 5, | ||
| LimitMonthBackward: 2, | ||
| LimitYearBackward: 2021, | ||
| }, | ||
| { | ||
| Pipeline: executor.Pipeline{ | ||
| Name: "Pipeline 02: Tolerância a falha", | ||
| }, | ||
| ID: "pipeline2", | ||
| Entity: "Tribunal Regional do Trabalho 13ª Região", | ||
| City: "João Pessoa", | ||
| FU: "PB", | ||
| Repo: "github.com/dadosjusbr/coletores", | ||
| Frequency: 30, | ||
| StartDay: 5, | ||
| LimitMonthBackward: 2, | ||
| LimitYearBackward: 2021, | ||
| }, | ||
| { | ||
| Pipeline: executor.Pipeline{ | ||
| Name: "Pipeline 03: Histórico", | ||
| }, | ||
| ID: "pipeline3", | ||
| Entity: "Pipeline 03", | ||
| City: "João Pessoa", | ||
| FU: "PB", | ||
| Repo: "github.com/dadosjusbr/coletores", | ||
| Frequency: 30, | ||
| StartDay: 5, | ||
| LimitMonthBackward: 2, | ||
| LimitYearBackward: 2021, | ||
| }, | ||
| } | ||
|
|
||
| type fakeFinder struct { | ||
|
|
||
| pipelines []storage.Pipeline | ||
| executions []storage.Execution | ||
| err error | ||
| } | ||
|
|
||
| func (fake fakeFinder) GetPipelinesByDay(day int) ([]storage.Pipeline, error) { | ||
| return fake.pipelines, fake.err | ||
| } | ||
| func (fake fakeFinder) InsertExecution(e storage.Execution) error { | ||
| return fake.err | ||
| } | ||
|
|
||
| // TODO: Retornar a última execução de cada pipeline | ||
| func (fake fakeFinder) GetLastExecutionsForAllPipelines() ([]storage.Execution, error) { | ||
| return fake.executions, fake.err | ||
| } | ||
|
|
||
| // TODO: Retornar as <limit> ultimas execuções daquele pipeline | ||
| func (fake fakeFinder) GetLastExecutionsByPipelineID(limit, id int) ([]storage.Execution, error) { | ||
| return fake.executions, fake.err | ||
| } | ||
|
|
||
| // PrioritizeAndLimit | ||
| // 1º descartar se o pipeline já tem uma execução finalizada com sucesso hoje | ||
| // 2º descartar se o número de execuções com erro for igual ou maior que o limite | ||
| // ... | ||
| // por último aplicar filtro de tamanho | ||
| func TestPrioritizeAndLimit_LimitTest(t *testing.T) { | ||
|
|
||
| is := is.New(t) | ||
| list := pipelinesDB | ||
| limit := 2 | ||
|
|
||
| finalPipelines := prioritizeAndLimit(fakeFinder{pipelines: pipelinesDB, err: nil}, list, limit) | ||
|
|
||
| is.True(len(finalPipelines) <= limit) | ||
| } | ||
|
|
||
| func TestPrioritizeAndLimit_PipelineWithMaxLimitOfFailure(t *testing.T) { | ||
| is := is.New(t) | ||
| list := pipelinesDB | ||
| limit := 3 | ||
|
|
||
| executions := []storage.Execution{ | ||
| { | ||
| PipelineResult: executor.PipelineResult{ | ||
| Name: "Pipeline 02", | ||
| Status: "Setup Error", | ||
| }, | ||
| ID: "pipeline2", | ||
| Entity: "Pipeline 02", | ||
| }, | ||
| { | ||
| PipelineResult: executor.PipelineResult{ | ||
| Name: "Pipeline 02", | ||
| Status: "Connection Error", | ||
| }, | ||
| ID: "pipeline2", | ||
| Entity: "Pipeline 02", | ||
| }, | ||
| { | ||
| PipelineResult: executor.PipelineResult{ | ||
| Name: "Pipeline 02", | ||
| Status: "Run Error", | ||
| }, | ||
| ID: "pipeline2", | ||
| Entity: "Pipeline 02", | ||
| }, | ||
| } | ||
|
|
||
| finalPipelines := prioritizeAndLimit(fakeFinder{executions: executions, err: nil}, list, limit) | ||
|
|
||
| is.True(len(finalPipelines) == 2) | ||
| } | ||
|
|
||
| func TestPrioritizeAndLimit_PipelineWithTwoFailures(t *testing.T) { | ||
| is := is.New(t) | ||
| list := pipelinesDB | ||
| limit := 3 | ||
|
|
||
| executions := []storage.Execution{ | ||
| { | ||
| PipelineResult: executor.PipelineResult{ | ||
| Name: "Pipeline 02", | ||
| Status: "Setup Error", | ||
| }, | ||
| ID: "pipeline2", | ||
| Entity: "Pipeline 02", | ||
| }, | ||
| { | ||
| PipelineResult: executor.PipelineResult{ | ||
| Name: "Pipeline 02", | ||
| Status: "Connection Error", | ||
| }, | ||
| ID: "pipeline2", | ||
| Entity: "Pipeline 02", | ||
| }, | ||
| } | ||
|
|
||
| finalPipelines := prioritizeAndLimit(fakeFinder{executions: executions, err: nil}, list, limit) | ||
|
|
||
| is.True(len(finalPipelines) == 3) | ||
| } | ||
|
|
||
| func TestPrioritizeAndLimit_PipelineWithSuccessfulExecution(t *testing.T) { | ||
| is := is.New(t) | ||
| list := pipelinesDB | ||
| limit := 3 | ||
|
|
||
| executions := []storage.Execution{ | ||
| { | ||
| PipelineResult: executor.PipelineResult{ | ||
| Name: "Pipeline 01", | ||
| Status: "OK", | ||
| }, | ||
| ID: "pipeline1", | ||
| Entity: "Pipeline 01", | ||
| }, | ||
| { | ||
| PipelineResult: executor.PipelineResult{ | ||
| Name: "Pipeline 02", | ||
| Status: "Setup Error", | ||
| }, | ||
| ID: "pipeline2", | ||
| Entity: "Pipeline 02", | ||
| }, | ||
| { | ||
| PipelineResult: executor.PipelineResult{ | ||
| Name: "Pipeline 03", | ||
| Status: "OK", | ||
| }, | ||
| ID: "pipeline3", | ||
| Entity: "Pipeline 03", | ||
| }, | ||
| } | ||
|
|
||
| finalPipelines := prioritizeAndLimit(fakeFinder{executions: executions, err: nil}, list, limit) | ||
|
|
||
| is.True(len(finalPipelines) == 1) | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Você provavelmente vai precisar passar algum tipo de quantidade aqui, não?
Outra coisa importante, a interface pode ser um bom lugar para documentar bem essas funções. Por exemplo, o método
GetPipelinesByDay(int)retorna todos os pipelines do dia especificado, sempre no mês corrente.