Run integration tests in single process #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…afny into directIntegrationTests
…afny into directIntegrationTests
robin-aws
reviewed
May 9, 2023
Comment on lines
+97
to
+101
| if (compiler.TargetId == "lib") { | ||
| // Some tests still fail when using the lib back-end, for example due to disallowed assumptions being present in the test, | ||
| // Such as empty constructors with ensures clauses, generated from iterators | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Ah this is how you kept it all green :) This is reasonable for now, but it'll be good to dig into those tests to see if the other backends are too permissive about this.
robin-aws
approved these changes
May 9, 2023
There was a problem hiding this comment.
LGTM, but FYI I turned off the auto-merge just to make @fabiomadge's life easier as he's trying to release 4.1. If he's fine releasing from a branch go ahead and merge!
fabiomadge
added a commit
to fabiomadge/dafny
that referenced
this pull request
May 11, 2023
This reverts commit 47056fd.
robin-aws
added a commit
to robin-aws/dafny
that referenced
this pull request
May 11, 2023
This reverts commit 47056fd.
fabiomadge
added a commit
that referenced
this pull request
May 11, 2023
keyboardDrummer
added a commit
to keyboardDrummer/dafny
that referenced
this pull request
May 12, 2023
)" (dafny-lang#3998)" This reverts commit 87300f2.
keyboardDrummer
added a commit
that referenced
this pull request
May 12, 2023
This reverts commit 87300f2. That revert was done because the commit caused this nightly build failure: https://github.com/dafny-lang/dafny/actions/runs/4949075745/jobs/8850690455 Some of the failures related to the libraries submodule which is removed now, but other like this one also didn't: ``` [xUnit.net 00:14:07.36] System.Exception : Command returned non-zero exit code (255): dotnet /home/runner/work/dafny/dafny/dafny/Source/IntegrationTests/bin/Debug/net6.0/TestDafny.dll for-each-compiler --dafny /home/runner/work/dafny/dafny/unzippedRelease/dafny/dafny TestFiles/LitTests/LitTest/unicodechars/comp/Arrays.dfy -- --unicode-char [xUnit.net 00:14:07.36] Output: [xUnit.net 00:14:07.36] [xUnit.net 00:14:07.36] Error: [xUnit.net 00:14:07.36] TestDafny 4.1.0 [xUnit.net 00:14:07.36] Copyright (C) 2023 TestDafny [xUnit.net 00:14:07.36] [xUnit.net 00:14:07.36] ERROR(S): [xUnit.net 00:14:07.36] Option 'dafny' is unknown. ``` From the code I don't see where the `--dafny` option could be coming from <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
dafny run --target=csnow uses a separate process to run, so the statics of the compiled source code, such asConsole, are not shared with the Dafny CompilerConsole.are replaced with non-static references.DafnyFileclass into its own fileThreadTaskSchedulerwhich creates one-shot threads, and instead use a thread pool. Also consistently use large threads for resolution, translation to Boogie, printing and compilation.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.