Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete a baseUrl from a marker-end to resolve the disappearance of a path's arrow #413

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

taketarouex
Copy link

This PR resolves the disappearance of a path's arrow in some use cases.
An arrowId is just enough to refer an arrow. And in some use cases, a baseUrl created by location.href causes a path's arrow to disappear.

For example, I use this library for drawing paths in a page whose url is changed by a user's action and set event listeners which change paths' color when users click them.
When the url is changed and one of the paths is clicked, it's arrow disappears.
Because it's mark-end reference url is invalid as a result of the difference between the url embedded when the path was rendered and the url changed by the user event.

I think the arrowId without the baseUrl is just enough to refer the arrow.
And to resolve the above matter, I propose deleting the baseUrl from the marker-end reference.

@tbo47
Copy link

tbo47 commented Jan 6, 2022

I ported the project to es6 and I accept contributions!
https://github.com/tbo47/dagre-es

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants