Skip to content

Commit

Permalink
[dagster-tableau] Pin tableauserverclient version (#25441)
Browse files Browse the repository at this point in the history
## Summary & Motivation

`dagster-tableau` tests fail
[here](https://buildkite.com/dagster/dagster-dagster/builds/99632#0192b583-1d7e-42fe-8973-3f0db3a12b3c)
for Python 3.8.

For some reasons, pip installed `tableauserverclient==0.19` for these
tests, which has a different implementation of `TSC.Server()` that is
not compatible with our implementation.

After investigating and testing locally, our implementation requires at
least `tableauserverclient` version 0.32, which is the first version to
implement the Datasources endpoint. This PR pins
`tableauserverclient>=0.32` in setup.py, which is compatible with Python
3.7+.

## How I Tested These Changes

Tested locally with Python 3.8.19 and 3.11.9
  • Loading branch information
maximearmstrong authored Oct 22, 2024
1 parent 1b3e659 commit cbc2ac8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion python_modules/libraries/dagster-tableau/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ def get_version() -> str:
install_requires=[
f"dagster{pin}",
"pyjwt[crypto]",
"tableauserverclient",
# Datasources endpoint were added in 0.32
"tableauserverclient>=0.32",
],
include_package_data=True,
python_requires=">=3.8,<3.13",
Expand Down

0 comments on commit cbc2ac8

Please sign in to comment.