Revert is_syncable property; rename to validate_syncable

dagster-io · Nov 21, 2024 · f43b3f6 · f43b3f6
1 parent f11aa91
commit f43b3f6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/python_modules/libraries/dagster-fivetran/dagster_fivetran/resources.py b/python_modules/libraries/dagster-fivetran/dagster_fivetran/resources.py
@@ -635,7 +635,7 @@ def _start_sync(self, request_fn: Callable[[], Mapping[str, Any]], connector_id:
         connector = FivetranConnector.from_connector_details(
             connector_details=self.get_connector_details(connector_id)
         )
-        connector.is_syncable()
+        connector.validate_syncable()
         if self.disable_schedule_on_trigger:
             self._log.info(f"Disabling Fivetran sync schedule for connector {connector_id}.")
             self.update_schedule_type_for_connector(connector_id, "manual")

diff --git a/python_modules/libraries/dagster-fivetran/dagster_fivetran/translator.py b/python_modules/libraries/dagster-fivetran/dagster_fivetran/translator.py
@@ -64,8 +64,7 @@ def is_connected(self) -> bool:
     def is_paused(self) -> bool:
         return self.paused
 
-    @property
-    def is_syncable(self) -> bool:
+    def validate_syncable(self) -> bool:
         """Confirms that the connector can be sync. Will raise a Failure in the event that
         the connector is either paused or not fully set up.
         """