[2/n] [RFC] add 'Launch all' button on sensor/schedule evaluation result modals #25323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 5e4eae5. |
hellendag
reviewed
Oct 18, 2024
| return <Button onClick={onClose}>Close</Button>; | ||
| return ( | ||
| <> | ||
| <Button intent="primary">Launch all</Button> |
There was a problem hiding this comment.
Looks like these will need onClick behavior added.
There was a problem hiding this comment.
Since this is a very minor change I would have included it in the linked pr
dliu27
force-pushed
the
dliu27/manual-sensors-oss
branch
from
89ff3c9
to
d9a3490
Compare
dliu27
force-pushed
the
dliu27/add-launch-all-fe
branch
2 times, most recently
from
8c5a3b7
to
efe8bf0
Compare
salazarm
approved these changes
Oct 31, 2024
dliu27
force-pushed
the
dliu27/manual-sensors-oss
branch
from
8866f99
to
a39ee99
Compare
dliu27
force-pushed
the
dliu27/add-launch-all-fe
branch
from
efe8bf0
to
b3de9f7
Compare
dliu27
force-pushed
the
dliu27/manual-sensors-oss
branch
from
a39ee99
to
d986a9f
Compare
dliu27
force-pushed
the
dliu27/add-launch-all-fe
branch
from
b3de9f7
to
5e4eae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Linear: https://linear.app/dagster-labs/issue/FE-627/add-launch-all-frontend
Add "Launch all" button to these evaluation result modals
How I Tested These Changes
Tested locally
Changelog