[3/n] [RFC] add manual tick button to all rows in automation table #25351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dliu27
changed the title
dliu27
changed the title
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 288ab5a. |
bengotow
approved these changes
Oct 21, 2024
js_modules/dagster-ui/packages/ui-core/src/automation/VirtualizedAutomationScheduleRow.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/automation/VirtualizedAutomationSensorRow.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/automation/VirtualizedAutomationSensorRow.tsx
Outdated
Show resolved
Hide resolved
dliu27
force-pushed
the
dliu27/add-launch-all-fe
branch
from
857bf23
to
8c5a3b7
Compare
dliu27
force-pushed
the
dliu27/add-manual-tick-to-automation-rows
branch
from
fdd4ce8
to
5cfc7d0
Compare
dliu27
force-pushed
the
dliu27/add-launch-all-fe
branch
from
8c5a3b7
to
efe8bf0
Compare
dliu27
force-pushed
the
dliu27/add-manual-tick-to-automation-rows
branch
from
5cfc7d0
to
7588c11
Compare
salazarm
reviewed
Oct 31, 2024
js_modules/dagster-ui/packages/ui-core/src/automation/VirtualizedAutomationScheduleRow.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Oct 31, 2024
js_modules/dagster-ui/packages/ui-core/src/automation/VirtualizedAutomationSensorRow.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Oct 31, 2024
js_modules/dagster-ui/packages/ui-core/src/ticks/EvaluateTickButtonSchedule.tsx
Show resolved
Hide resolved
salazarm
approved these changes
Oct 31, 2024
bengotow
approved these changes
Nov 8, 2024
js_modules/dagster-ui/packages/ui-core/src/automation/VirtualizedAutomationScheduleRow.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/automation/VirtualizedAutomationScheduleRow.tsx
Show resolved
Hide resolved
dliu27
force-pushed
the
dliu27/add-launch-all-fe
branch
from
efe8bf0
to
b3de9f7
Compare
dliu27
force-pushed
the
dliu27/add-manual-tick-to-automation-rows
branch
2 times, most recently
from
9e8213d
to
4406df6
Compare
dliu27
force-pushed
the
dliu27/add-launch-all-fe
branch
from
b3de9f7
to
5e4eae5
Compare
dliu27
force-pushed
the
dliu27/add-manual-tick-to-automation-rows
branch
from
4406df6
to
288ab5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Linear: https://linear.app/dagster-labs/issue/FE-628/add-manual-tick-button-to-all-rows-in-automations-table
Video:
Recording.at.2024-10-17.17.51.08.mp4
How I Tested These Changes
yarn lint, ts, tested locally
Changelog