Rename relation identifier to table name #25400
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @clairelin135 and the rest of your teammates on |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-8i4bou3y5-elementl.vercel.app Direct link to changed pages: |
|
Deploy preview for dagster-docs-beta ready! Preview available at https://dagster-docs-beta-jbtv2ly29-elementl.vercel.app Direct link to changed pages: |
clairelin135
force-pushed
the
10-21-claire/relation-identifier-to-table-name
branch
2 times, most recently
from
fe4ac9f
to
edd0a89
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b1dbce9. |
| m: MetadataEntryLabelOnly, | ||
| ): m is TextMetadataEntry => m && m.label === 'dagster/relation_identifier'; | ||
| export const isCanonicalTableNameEntry = (m: MetadataEntryLabelOnly): m is TextMetadataEntry => | ||
| m && (m.label === 'dagster/relation_identifier' || m.label === 'dagster/table_name'); |
There was a problem hiding this comment.
This looks good to me.
Confirmed that no case insensitive relation_identifier or relation identifier exists in the monorepo apart from a couple of comments.
There are some programmatic names, like RelationKey.identifier in dagster-dbt but these are not forward facing.
clairelin135
force-pushed
the
10-21-claire/relation-identifier-to-table-name
branch
from
edd0a89
to
12c741a
Compare
clairelin135
force-pushed
the
10-21-claire/relation-identifier-to-table-name
branch
from
12c741a
to
b1dbce9
Compare
clairelin135
deleted the
10-21-claire/relation-identifier-to-table-name
branch
## Summary & Motivation Rename relation identifier to table name to increase clarity. [Context here](https://dagsterlabs.slack.com/archives/C06AWMPT3DF/p1729269974738339). Does a direct rename to switch references from `relation_identifier` to `table_name`, since integration packages should have the same version as the dagster package. In the UI, to handle backcompat, display metadata with either key. ## How I Tested These Changes BK ## Changelog Renames the `dagster/relation_identifier` metadata key to `dagster/table_name`.
Summary & Motivation
Rename relation identifier to table name to increase clarity. Context here.
Does a direct rename to switch references from
relation_identifiertotable_name, since integration packages should have the same version as the dagster package.In the UI, to handle backcompat, display metadata with either key.
How I Tested These Changes
BK
Changelog
Renames the
dagster/relation_identifiermetadata key todagster/table_name.