[dagster-airlift] [api-docs] in-airflow section #25692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2024
This was referenced Nov 1, 2024
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-phnjypi9l-elementl.vercel.app Direct link to changed pages: |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
examples/experimental/dagster-airlift/dagster_airlift/in_airflow/proxying_fn.py
Outdated
Show resolved
Hide resolved
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
b550d3b
to
8a5142b
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
c7ddb77
to
8f2e0c3
Compare
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
8a5142b
to
729fc69
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
8f2e0c3
to
e3208b2
Compare
| proxying_to_dagster( | ||
| proxied_state=load_proxied_state_from_yaml(Path(__file__).parent / "proxied_state"), | ||
| global_vars=globals(), | ||
| build_from_dag_fn=custom_build_from_dag_fn, |
There was a problem hiding this comment.
The example references custom_build_from_dag_fn, but this variable isn't defined. Based on the example code above, this should be CustomAuthDAGProxyOperator.build_from_dag to match the class method implementation.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
examples/experimental/dagster-airlift/dagster_airlift/in_airflow/proxying_fn.py
Outdated
Show resolved
Hide resolved
This was referenced Nov 1, 2024
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
729fc69
to
2e08a6e
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
e3208b2
to
b891cd8
Compare
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
2e08a6e
to
7573b9e
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
b891cd8
to
6c5f547
Compare
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
7573b9e
to
b5158b2
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
6c5f547
to
7db5c61
Compare
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
b5158b2
to
65537ea
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
7db5c61
to
019f13d
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
2 times, most recently
from
a700b73
to
796ef48
Compare
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
ef76b25
to
d66d4d1
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
796ef48
to
614ea46
Compare
|
Deploy preview for dagster-docs-beta ready! Preview available at https://dagster-docs-beta-ewnyotw10-elementl.vercel.app Direct link to changed pages: |
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
614ea46
to
80bc0f1
Compare
Comment on lines
+96
to
+99
| if task.task_id == "my_task_needs_more_retries": | ||
| return CustomAuthTaskProxyOperator(task_id=task_id, retries=3) | ||
| else: | ||
| return CustomAuthTaskProxyOperator(task_id=task_id) |
There was a problem hiding this comment.
The variable task_id in this example is undefined - it should reference the task's ID via task.task_id. Here's the corrected code:
if task.task_id == "my_task_needs_more_retries":
return CustomAuthTaskProxyOperator(task_id=task.task_id, retries=3)
else:
return CustomAuthTaskProxyOperator(task_id=task.task_id)Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
cmpadden
approved these changes
Nov 7, 2024
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
d66d4d1
to
85675c1
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
80bc0f1
to
51abea2
Compare
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
85675c1
to
25a1908
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
51abea2
to
5b40255
Compare
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
25a1908
to
3e41d65
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
5b40255
to
0b65288
Compare
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
3e41d65
to
c74f9e3
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
0b65288
to
e8d4b33
Compare
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
c74f9e3
to
8317171
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
e8d4b33
to
59b72b2
Compare
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
8317171
to
1cb706e
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
59b72b2
to
4bac474
Compare
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
1cb706e
to
d78ecda
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
4bac474
to
036db8b
Compare
dpeng817
force-pushed
the
dpeng817/docs/mapping
branch
from
d78ecda
to
6ca006a
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
036db8b
to
ff64f05
Compare
dpeng817
force-pushed
the
dpeng817/docs/in-airflow
branch
from
ff64f05
to
b841062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Scaffold out in-airflow section, docstrings for all the operators and the main
proxying_to_dagsterfunction.How I Tested These Changes
Eyes