[ui] Fix vertical centering of arrows on the asset graph, asset name wrapping #25974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit c9564c3. |
bengotow
force-pushed
the
bengotow-2024-11/FE-481
branch
from
1f4dece
to
5d0aae2
Compare
bengotow
force-pushed
the
bengotow-2024-11/FE-481
branch
from
5d0aae2
to
6d20966
Compare
bengotow
force-pushed
the
bengotow-2024-11/FE-481
branch
from
e7e3241
to
c9564c3
Compare
hellendag
approved these changes
Nov 19, 2024
| <div | ||
| style={{ | ||
| position: 'relative', | ||
| width: dimensions.width, | ||
| height: dimensions.height, | ||
| background: `linear-gradient(to bottom, rgba(100,100,100,0.15) 49%, rgba(100,100,100,1) 50%, rgba(100,100,100,0.15) 51%)`, |
There was a problem hiding this comment.
I know it's just Storybook, but does this look okay in light mode?
There was a problem hiding this comment.
Ahh let me double check, that's a good question...
salazarm
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This fixes a couple specific issues with the asset graph and updates our AssetNode stories:
getAssetNodeDimensionsfunction to reflect what is actually rendered and ensure theAssetNodeBoxis always centered in the layout box so that horizontal edges hit the middle of the box. To make this easier I updated the storybooks to show the overall box in a gray color and draw a midline where edges will arrive. I think it'd been a while since we updated this and in a bunch of cases there was too much padding at the bottom of the box, which we were compensating for by giving asset groups a negative margin.How I Tested These Changes
A few new storybook cases covering kind tags and combinations of checks + partitions + change reasons.
app-proxy testing against elementl prod's global graph, both in horizontal and vertical mode and looking at maximally-tall assets at the bottom of asset groups: