[dagster-airlift] Airflow-dagster equivalents #26112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 23, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
8365a1f
to
267d5ec
Compare
dpeng817
force-pushed
the
dpeng817/airflow-dagster-equivalents
branch
2 times, most recently
from
c931603
to
10abc83
Compare
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
267d5ec
to
7f90cc5
Compare
dpeng817
force-pushed
the
dpeng817/airflow-dagster-equivalents
branch
from
10abc83
to
844a298
Compare
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
7f90cc5
to
e7d0535
Compare
dpeng817
force-pushed
the
dpeng817/airflow-dagster-equivalents
branch
from
844a298
to
2534e40
Compare
Graphite Automations"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (11/24/24)1 label was added to this PR based on Christopher DeCarolis's automation. |
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
e7d0535
to
b84bce9
Compare
dpeng817
force-pushed
the
dpeng817/airflow-dagster-equivalents
branch
2 times, most recently
from
cba5d13
to
781771a
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+9
to
+10
| def _s3_file(context): | ||
| boto3.client("s3").upload_file(path) |
There was a problem hiding this comment.
The context parameter is unused and can be removed. The upload_file call is missing required parameters - the correct signature is:
boto3.client('s3').upload_file(path, 'bucket', path)where bucket is the destination S3 bucket name and the final path argument specifies the S3 key.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
dpeng817
force-pushed
the
dpeng817/python_operator_docs
branch
from
b84bce9
to
3b3ee96
Compare
dpeng817
force-pushed
the
dpeng817/airflow-dagster-equivalents
branch
from
781771a
to
5786b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog