[dagster-fivetran] Use Fivetran translator instance in load specs fn and state-backed defs #26133
+101
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and state-backed defs
This was referenced Nov 25, 2024
Open
Merged
[5/n][dagster-fivetran] Implement
FivetranWorkspaceData to FivetranConnectorTableProps method
#25797
Merged
This was referenced Nov 25, 2024
schrockn
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Updates load_fivetran_asset_specs() and state-backed definitions to accept an instance of
DagsterFivetranTranslator.See more about the motivation in the original thread here.
How I Tested These Changes
Additional unit tests to test custom translators with BK
Changelog
[dagster-fivetran]
load_fivetran_asset_specsis updated to accept an instance ofDagsterFivetranTranslatoror custom subclass.