Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow integer values for multi #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oerpli
Copy link

@oerpli oerpli commented Feb 15, 2020

Since 0.19.0, an optional integer value can be passed to --multi which indicates the maximum number of items that can be selected.

Added this by changing the default from False to None and checking the type and adding the appropriate argument.

Copy link
Owner

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

iterfzf/__init__.py Outdated Show resolved Hide resolved
iterfzf/__init__.py Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
iterfzf/__init__.py Outdated Show resolved Hide resolved
iterfzf/__init__.py Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
@oerpli
Copy link
Author

oerpli commented Apr 13, 2020

I had a pretty embarrassing error (& an if instead of an elif) in the argument handling logic previously which should be fixed now.

@oerpli oerpli requested a review from dahlia May 14, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants