add header and color options

[mvrozanti]

No description provided.

[daturkel]

This would be a great feature. I'd love to help get it merged but I can't tell what is failing in the CI. Any help @dahlia ?

[mvrozanti]

I see a message about python 2 usage on the beggining of the console output. Maybe this has something to do with it?

[daturkel]

I'm guessing the python2 tests are failing with the f-string syntax. Try replacing:
f'{k}:{v}'
with
str(k) + ":" + str(v)

[mvrozanti]

I just replaced this part but the build still fails. That's weird

[daturkel]

this one looks like a different error. i defer to @dahlia who probably has a better understanding of the CI setup. but the syntax error from before is gone and now we just have:

lint run-test: commands[0] | flake8 iterfzf.py setup.py
iterfzf.py:0:1: E902 FileNotFoundError: [Errno 2] No such file or directory: 'iterfzf.py'
ERROR: InvocationError for command 'C:\projects\iterfzf\.tox\lint\Scripts\flake8.EXE' iterfzf.py setup.py (exited with code 1)

[dahlia]

@mvrozanti Sorry for my late response. As @daturkel explained, it was an error that has existed before changes you made, and I finally fixed the error in the master. The error would be gone if you rebase your commits on the current master.

[mvrozanti]

Still failing 😕 .

I actually just tried pulling from upstream. Do I really need to rebase?

[dahlia]

• Please make its style consistent with the existing code. You can run the lint to check style: tox -e lint (you should install tox first: pip install tox). FYI the CI build is failing due to style inconsistencies:

  iterfzf\__init__.py:55:70: E231 missing whitespace after ','
  iterfzf\__init__.py:55:80: E501 line too long (91 > 79 characters)
  

• Please write changelogs in the README.md file.

[dahlia]

Could you move header parameter to # Layout: section? It looks more appropriate there.

[dahlia]

Suggested change

	from typing import Dict, AnyStr, Iterable, Optional
	from typing import AnyStr, Dict, Iterable, Optional

Imports should be listed in lexicographical order.