feat: clear image based on preset #2488
Open
+119
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshanzel
requested review from
rebelchris,
omBratteng,
ilasw,
nensidosari and
AmarTrebinjac
capJavert
approved these changes
Nov 25, 2024
| @@ -1770,6 +1779,31 @@ export const resolvers: IResolvers<unknown, BaseContext> = traceResolvers< | |||
| }, | |||
| }, | |||
| Mutation: { | |||
| clearImage: async ( | |||
| _, | |||
| { preset }: { preset: UploadPreset }, | |||
There was a problem hiding this comment.
maybe preset can be an array so we can remove in a single go as well? Not blocking.
| @@ -49,10 +49,10 @@ export class User { | |||
| email: string; | |||
|
|
|||
| @Column({ type: 'text', nullable: true }) | |||
| image: string; | |||
| image?: string | null; | |||
Comment on lines
+1789
to
+1791
| await con.getRepository(User).update(userId, { | ||
| cover: null, | ||
| }); |
There was a problem hiding this comment.
Suggested change
| await con.getRepository(User).update(userId, { | |
| cover: null, | |
| }); | |
| await con.getRepository(User).update( | |
| { | |
| id: userId, | |
| }, | |
| { | |
| cover: null, | |
| }, | |
| ); |
just to be more safe that we are targeting id column, also adjust below
| @@ -104,6 +104,16 @@ type PostPreset = | |||
| | UploadPreset.FreeformImage | |||
| | UploadPreset.FreeformGif; | |||
|
|
|||
| export const clearFile = (referenceId: string, preset: UploadPreset) => { | |||
| if (!process.env.CLOUDINARY_URL) { | |||
| return Promise.resolve(); | |||
There was a problem hiding this comment.
Suggested change
| return Promise.resolve(); | |
| return |
| @@ -104,6 +104,16 @@ type PostPreset = | |||
| | UploadPreset.FreeformImage | |||
| | UploadPreset.FreeformGif; | |||
|
|
|||
| export const clearFile = (referenceId: string, preset: UploadPreset) => { | |||
There was a problem hiding this comment.
use object syntax { referenceId, preset }, easier to add new params later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having a nullable prop that would signify that we should clear the image on certain mutations, we introduced a mutation to specifically do it. This makes maintaining how the clearance works much easier than remembering the meaning of the passed null values.