correct PHP < 8.2 issue with empty path string

dakujem · Jan 19, 2024 · 5e26064 · 5e26064
1 parent e685b6e
commit 5e26064
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/MaterializedPath/TreeBuilder.php b/src/MaterializedPath/TreeBuilder.php
@@ -71,7 +71,7 @@ public static function fixed(int $levelWidth, callable $accessor): callable
     {
         return function (mixed $data) use ($levelWidth, $accessor): array {
             $path = $accessor($data);
-            if (null === $path) {
+            if (null === $path || $path === '') {
                 return [];
             }
             if (!is_string($path)) {

diff --git a/tests/mptree.phpt b/tests/mptree.phpt
@@ -86,6 +86,7 @@ class Item
     );
     Assert::same(['000', '000'], $vectorExtractor('000000'));
     Assert::same(['foo', 'bar'], $vectorExtractor('foobar'));
+    Assert::same(['x'], $vectorExtractor('x')); // shorter than 3
     Assert::same([], $vectorExtractor(''));
     Assert::same([], $vectorExtractor(null));
     Assert::throws(function () use ($vectorExtractor) {