Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems some changes I force pushed to #123 didn't wind up getting merged. In that PR, I noted that
pub const fn new
was MSRV breaking and got rid of theconst
but that didn't end up indevelop
.I also encountered a build failure on
develop
since the legacyblack_box
function wasn't gated on thecore_hint_black_box
feature and thus clashed withcore::hint::black_box
when it was imported:This is a breaking change since we shipped a
const fn
forBlackBox::new
already, so I'd suggest releasing this as 2.6.1 and yanking 2.6.0 for being unintentionally MSRV breaking.