Add a marker trait for equality testing #131
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a (fairly?) common design pattern to have certain types use
ConstantTimeEq
to implementEq
(viaPartialEq
) for improved safety. For example,curve2519-dalek
does this for itsScalar
andRistrettoPoint
types by coercing the resultingChoice
into abool
.It would be useful to be able to signal to implementers if a type does this. Otherwise, for some applications the only way to guarantee that a type supporting
ConstantTimeEq
uses it for all equality testing is to check this yourself, and it makes it tricky if you want to do this to build more complex traits.This PR adds a new
EqIsConstantTimeEq
marker trait. The intent is to have types that follow this design pattern use it as a signal to implementers.