Builds with JDK 17

damianszczepanik · Jan 1, 2024 · 7468e17 · 7468e17
1 parent b4d5ba7
commit 7468e17
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 6 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -23,7 +23,7 @@ jobs:
 
       - uses: actions/setup-java@v3
         with:
-          java-version: 11
+          java-version: 17
           distribution: adopt
 
       - run: mvn --batch-mode verify
diff --git a/.github/workflows/checkstyle.yml b/.github/workflows/checkstyle.yml
@@ -19,7 +19,7 @@ jobs:
 
       - uses: actions/setup-java@v3
         with:
-          java-version: 11
+          java-version: 17
           distribution: adopt
 
       - name: Generate demo report

diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml
@@ -19,7 +19,7 @@ jobs:
 
       - uses: actions/setup-java@v3
         with:
-          java-version: 11
+          java-version: 17
           distribution: adopt
 
       - name: Generate code coverage

diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml
@@ -4,6 +4,7 @@ on:
   push:
     branches:
       - master
+      - jdk17
   # do not validate pull requests because SONAR_TOKEN is available only for project owner
 
 jobs:
@@ -17,7 +18,7 @@ jobs:
 
       - uses: actions/setup-java@v3
         with:
-          java-version: 11
+          java-version: 17
           distribution: adopt
 
       - name: Build with Maven

diff --git a/pom.xml b/pom.xml
@@ -170,6 +170,10 @@
                 <artifactId>maven-surefire-plugin</artifactId>
                 <version>3.2.2</version>
                 <configuration>
+                    <!-- Allow JUnit to access the test classes -->
+                    <argLine>
+                        --add-opens java.base/java.lang=ALL-UNNAMED
+                    </argLine>
                     <systemPropertyVariables>
                         <!-- JaCoCo runtime must know where to dump coverage: -->
                         <jacoco-agent.destfile>target/jacoco.exec</jacoco-agent.destfile>

diff --git a/src/main/java/pl/szczepanik/silencio/processors/visitors/AbstractJacksonVisitor.java b/src/main/java/pl/szczepanik/silencio/processors/visitors/AbstractJacksonVisitor.java
@@ -14,8 +14,13 @@
  * @author Damian Szczepanik (damianszczepanik@github)
  */
 public abstract class AbstractJacksonVisitor extends AbstractVisitor {
-
-    @SuppressWarnings("unchecked")
+
+    /**
+     * Process map or array/list objects.
+     *
+     * @param key   key
+     * @param value value that should be converted
+     */
     protected void processComplex(String key, Object value) {
         if (isMap(value)) {
             processMap((Map<String, Object>) value);
@@ -26,6 +31,11 @@ protected void processComplex(String key, Object value) {
         }
     }
 
+    /**
+     * Process map object.
+     *
+     * @param map value that should be converted
+     */
     protected void processMap(Map<String, Object> map) {
         for (Map.Entry<String, Object> keyMap : map.entrySet()) {
             String key = keyMap.getKey();
@@ -39,6 +49,11 @@ protected void processMap(Map<String, Object> map) {
         }
     }
 
+    /**
+     * Process array/list object.
+     *
+     * @param list value that should be converted
+     */
     private void processArray(String key, List<Object> list) {
         for (int i = 0; i < list.size(); i++) {
             Object value = list.get(i);