Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves smell code: Remove this 'public' modifier #182

Merged
merged 1 commit into from
Jan 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/java/pl/szczepanik/silencio/api/FormatTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class FormatTest extends GenericTest {
class FormatTest extends GenericTest {

@Test
void shouldReturnFormatName() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class BlankTest extends GenericTest {
class BlankTest extends GenericTest {

@Test
void shouldReturnEmptyValue() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class NumberSequenceConverterTest extends GenericTest {
class NumberSequenceConverterTest extends GenericTest {

@Test
void shouldReturnValueWhenPassingNull() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class StringConverterTest extends GenericTest {
class StringConverterTest extends GenericTest {

@Test
void shouldReturnEmptyValue() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class WikipediaConverterTest extends GenericTest {
class WikipediaConverterTest extends GenericTest {

private static final String URL_ADDRESS = "https://en.m.wikipedia.org/wiki/Special:Random";
private static final String INVALID_HTML_PAGE = "This does not look like valid HTML page";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class AbstractProcessorTest extends GenericTest {
class AbstractProcessorTest extends GenericTest {

@Test
void shouldReturnPassedFormat() {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/pl/szczepanik/silencio/core/BuilderTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class BuilderTest extends GenericTest {
class BuilderTest extends GenericTest {

@Test
void shouldHoldPassedFormat() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class BuilderTest_buildTest extends GenericTest {
class BuilderTest_buildTest extends GenericTest {

public Format format;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class ConfigurationTest extends GenericTest {
class ConfigurationTest extends GenericTest {

@Test
void shouldReturnPassedExecutions() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class ExecutionTest extends GenericTest {
class ExecutionTest extends GenericTest {

@Test
void shouldReturnPassedValues() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class IntegrityExceptionTest extends GenericTest {
class IntegrityExceptionTest extends GenericTest {

@Test
void constructorWithMessageReturnsPassedMessage() {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/pl/szczepanik/silencio/core/KeyTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class KeyTest extends GenericTest {
class KeyTest extends GenericTest {

@Test
void shouldReturnKey() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class ProcessorExceptionTest extends GenericTest {
class ProcessorExceptionTest extends GenericTest {

@Test
void constructorWithMessageReturnsPassedMessage() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class ProcessorStateMachineTest extends GenericTest {
class ProcessorStateMachineTest extends GenericTest {

@Test
void shouldNotAllowToValidateProcessInCreatedState() {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/pl/szczepanik/silencio/core/ValueTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class ValueTest extends GenericTest {
class ValueTest extends GenericTest {

@Test
void shouldReturnValue() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class MatcherDecisionTest extends GenericTest {
class MatcherDecisionTest extends GenericTest {

@Test
void shouldAcceptValuesAsWords() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class NegativeDecisionTest extends GenericTest {
class NegativeDecisionTest extends GenericTest {

@Test
void shouldNotAllowForConversion() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class PositiveDecisionTest extends GenericTest {
class PositiveDecisionTest extends GenericTest {

@Test
void shouldAllowForConversion() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import pl.szczepanik.silencio.core.Key;
import pl.szczepanik.silencio.core.Value;

public class BlankCharConverterTest extends GenericTest {
class BlankCharConverterTest extends GenericTest {

@Test
void shouldReturnConstantValue() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import pl.szczepanik.silencio.core.Key;
import pl.szczepanik.silencio.core.Value;

public class ConstantValueConverterTest extends GenericTest {
class ConstantValueConverterTest extends GenericTest {

@Test
void shouldReturnConstantValue() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import pl.szczepanik.silencio.core.Key;
import pl.szczepanik.silencio.core.Value;

public class KeyValueConverterTest extends GenericTest {
class KeyValueConverterTest extends GenericTest {

@Test
void shouldReturnCorrectValue() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import pl.szczepanik.silencio.core.Key;
import pl.szczepanik.silencio.core.Value;

public class PassedValueConverterTest extends GenericTest {
class PassedValueConverterTest extends GenericTest {

@Test
void shouldReturnCorrectValue() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class ProcessorSmokeCheckerTest extends GenericTest {
class ProcessorSmokeCheckerTest extends GenericTest {

@Test
void shouldPassWithStubProcessor() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class BlankConverterIntegrationTest extends GenericTest {
class BlankConverterIntegrationTest extends GenericTest {

@Test
void shoulClearValuesWhenBlankIsExecutedAsLast() throws IOException {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class BuilderIntegrationTest extends GenericTest {
class BuilderIntegrationTest extends GenericTest {

@Test
void shouldProcessPropertiesFile() throws IOException {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class EmptyContentIntegrationTest extends GenericTest {
class EmptyContentIntegrationTest extends GenericTest {

public Format format;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class JSONProcessorIntegrationTest extends GenericTest {
class JSONProcessorIntegrationTest extends GenericTest {

@Test
void shouldProcessJSONFile() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class PropertiesProcessorIntegrationTest extends GenericTest {
class PropertiesProcessorIntegrationTest extends GenericTest {

@Test
void shouldProcessPropertiesFile() throws IOException {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class SuvIntegrationTest extends GenericTest {
class SuvIntegrationTest extends GenericTest {

public Processor processor;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class WikipediaConverterIntegrationTest extends GenericTest {
class WikipediaConverterIntegrationTest extends GenericTest {

@Test
void shouldGetWordsFromWikipedia() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class XMLProcessorIntegrationTest extends GenericTest {
class XMLProcessorIntegrationTest extends GenericTest {

@Test
void shouldProcessXMLFile() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* Mock for {@link AbstractProcessor} that crashes when {@link AbstractProcessorCrashOnRealProcess#realProcess()} method
* is invoked.
*
*
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class AbstractProcessorCrashOnRealProcess extends StubProcessor {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

/**
* Stores key and value passed to this converter.
*
*
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class ConverterVisitor implements Converter {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

/**
* Counts how many {{@link #} {@link #process(Properties)} method has been invoked.
*
*
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class PropertyVisitorHolder extends PropertiesVisitor {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

/**
* Writer that throws exception when {@link #write(char[], int, int)}} method is invoked.
*
*
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class WriterCrashOnWrite extends Writer {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class JSONParser_isBasicTypeTest extends GenericTest {
class JSONParser_isBasicTypeTest extends GenericTest {

public Object type;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class JSONProcessorTest extends GenericTest {
class JSONProcessorTest extends GenericTest {

@Test
void shouldReturnPassedFormat() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class PropertiesProcessorTest extends GenericTest {
class PropertiesProcessorTest extends GenericTest {

@Test
void shouldReturnPassedFormat() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class XMLProcessorTest extends GenericTest {
class XMLProcessorTest extends GenericTest {

@Test
void shouldReturnPassedFormat() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class YAMLProcessorTest extends GenericTest {
class YAMLProcessorTest extends GenericTest {

@Test
void shouldReturnPassedFormat() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class AbstractVisitorTest extends GenericTest {
class AbstractVisitorTest extends GenericTest {

@Test
void shouldFailWhenPassingValueToProcessValue() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class AbstractVisitor_processValueTest extends GenericTest {
class AbstractVisitor_processValueTest extends GenericTest {

private static final Key key = new Key("myKey");
private static final Object value = "yourValue";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class JSONVisitorTest extends GenericTest {
class JSONVisitorTest extends GenericTest {

@Test
void shouldReportExceptionOnUnsupportedModel() throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* @author Damian Szczepanik (damianszczepanik@github)
*/
public class PropertiesVisitorTest extends GenericTest {
class PropertiesVisitorTest extends GenericTest {

@Test
void shouldVisitAllJsonNodes() throws IOException {
Expand Down
Loading