Merge pull request #1825 from andsouto/logoff-url-handler-problem

fix problem in logoff when urlHandler option is present
damienbod · Aug 22, 2023 · bd73ff2 · bd73ff2
2 parents da67bb5 + 54d893a
commit bd73ff2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/projects/angular-auth-oidc-client/src/lib/logoff-revoke/logoff-revocation.service.spec.ts b/projects/angular-auth-oidc-client/src/lib/logoff-revoke/logoff-revocation.service.spec.ts
@@ -8,8 +8,8 @@ import { ResetAuthDataService } from '../flows/reset-auth-data.service';
 import { CheckSessionService } from '../iframe/check-session.service';
 import { LoggerService } from '../logging/logger.service';
 import { StoragePersistenceService } from '../storage/storage-persistence.service';
-import { UrlService } from '../utils/url/url.service';
 import { RedirectService } from '../utils/redirect/redirect.service';
+import { UrlService } from '../utils/url/url.service';
 import { LogoffRevocationService } from './logoff-revocation.service';
 
 describe('Logout and Revoke Service', () => {
@@ -481,6 +481,10 @@ describe('Logout and Revoke Service', () => {
         spy(url);
       };
       const redirectSpy = spyOn(redirectService, 'redirectTo');
+      const resetAuthorizationDataSpy = spyOn(
+        resetAuthDataService,
+        'resetAuthorizationData'
+      );
 
       spyOn(checkSessionService, 'serverStateChanged').and.returnValue(false);
       const config = { configId: 'configId1' };
@@ -492,6 +496,7 @@ describe('Logout and Revoke Service', () => {
       result$.subscribe(() => {
         expect(redirectSpy).not.toHaveBeenCalled();
         expect(spy).toHaveBeenCalledOnceWith('someValue');
+        expect(resetAuthorizationDataSpy).toHaveBeenCalled();
       });
     }));
 

diff --git a/projects/angular-auth-oidc-client/src/lib/logoff-revoke/logoff-revocation.service.ts b/projects/angular-auth-oidc-client/src/lib/logoff-revoke/logoff-revocation.service.ts
@@ -69,6 +69,7 @@ export class LogoffRevocationService {
         `Custom UrlHandler found. Using this to handle logoff with url '${endSessionUrl}'`
       );
       urlHandler(endSessionUrl);
+      this.resetAuthDataService.resetAuthorizationData(config, allConfigs);
 
       return of(null);
     }