000559 #67
Merged
000559 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, @pauladkisson ! Could you also please add an environment.yml file? See instructions in the readme. |
|
@pauladkisson it looks like 2 of these files are empty |
Yes, hence why this PR is still in draft. For the figure 1D reproduction I am waiting for some missing data. For the figure S3 reproduction I am waiting for alignment data frames for the key points. |
|
@bendichter this is ready to go now! |
bendichter
approved these changes
Feb 21, 2024
|
@pauladkisson why is the metadata yaml file in here? |
bendichter
requested changes
Feb 21, 2024
bendichter
approved these changes
Feb 22, 2024
|
@bendichter Is this ready for merge? |
|
note that this PR was merged while CI was red with not only unrelated but 1 related typo ... will fix up for that now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 Notebooks reproduce figures from Spontaneous behaviour is structured by reinforcement without explicit reward for conversion of Datta Lab data.