Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and extend (OPEN vs EMBARGOED; more data types and species mapped) stats for DANDI #71

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Update and extend (OPEN vs EMBARGOED; more data types and species mapped) stats for DANDI #71

merged 2 commits into from
Sep 5, 2024

Conversation

yarikoptic
Copy link
Member

Here are previews of some plots

image

image

@yarikoptic
Copy link
Member Author

apparently codespell isn't happy -- will send fixes in a separate PR

@bendichter
Copy link
Member

This is now really only meaningful if the user that runs it has admin privileges. For example, if I run this I only get 4 embargoed dandisets, since I am only an owner of 4. Given that, I think I'd rather this be in a separate place, distinct from the DANDI summary commands that can be run by any user.

@yarikoptic
Copy link
Member Author

yarikoptic commented Mar 1, 2024 •
edited
Loading

Well, I didn't realize this would be of interest to a regular user.

"separate place" == "duplication" == divergence of implementations etc. So I would really hope that we could avoid that.

Let me offer two solutions in the order of my preference ;)

  • Just provide documentation/description summarizing what @bendichter mention
  • make it by default without embargoed but possible to enable/change the style happen one of us decides to use it for stats

WDYT @bendichter ?

NB thinking out loud... ideally we should just make this notebook run e.g. weekly and place those images somewhere on the website for up-to-date informatio

@satra
Copy link
Member

satra commented Mar 1, 2024

i may have posted an issue to generate this dashboard directly on top of django, i.e. by our backend :)

@yarikoptic
Update and extend (OPEN vs EMBARGOED; more data types and species map…
833837b 
…ped) stats for DANDI
@yarikoptic
Added explicit variable for embargoed so users without account could …
f15c447 
…switch and run

Verified that it runs/renders fine with False.
Reran for up to date stats
@yarikoptic
Copy link
Member Author

ok, I have added explicit embargoed = True and a comment so anon users could flip it if desired. Verified that it still works.

I rebased and reran so it is uptodate ATM. I addressed typo directly in master, rebased again...

@bendichter -- are you ok with this? (@satra already blessed PR)

@yarikoptic
Copy link
Member Author

here is how that cell looks like now
image

bendichter
bendichter approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@bendichter bendichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yarikoptic
Copy link
Member Author

oh, it was approved! Let's proceed!

@yarikoptic yarikoptic merged commit 1eaffba into master Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendichter bendichter bendichter approved these changes

@satra satra satra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yarikoptic @bendichter @satra