Visual Coding (Ophys) Tutorial #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something interesting is that the GitHub preview for notebooks fully expands all HTML dropdowns by default - the biggest offenders of this seem to be the nested ROI links inside RoiReponseSeries types |
|
@CodyCBakerPhD wow, this is awesome! Did you say this was based on an original notebook Saskia gave you? Could you provide a link and explanation of that either in the README or in the notebook itself? Otherwise, looks great! |
|
@bendichter Added a blurb about the source notebook this was adapted from: |
|
OK, this looks good to me. Let me know when the dependencies reach a stable point and this is ready to merge |
|
@bendichter OK, pinned to latest PyNWB and checked that it still works, this should be good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bendichter This is finally ready for review
We should hold off on merging (or I can fix post-merge) once the latest PyNWB has been released so I can update the frozen conda environment (currently pointing to a dev branch out of necessity around the stimulus group bug)