-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image support #65
base: master
Are you sure you want to change the base?
Image support #65
Conversation
b9b7c8a
to
958dc1e
Compare
Well this hack doesn't hold up very well to sorting, narrowing, widening etc. I'm gonna close this and mess around some more to find a possibly less hacky way to accomplish this. |
Hey @danielfm I got this pretty well working! Works for track and playlist search. I ended up putting the image in the left margin so it didn't jam up spacing of the actual table. Adds maybe 1-2 sec to include images. Not too noticeable. Wanna give it a look? |
I´ll try this later. I think we should expose a flag for activating this feature, which defaults to not fetch images. Do you agree? |
I do agree. There is a config but it defaults to true. Maybe defaulting to false is better. Or maybe default depending on terminal vs gui? |
@danielfm I thought this could be fun. Let me know what you think.