Allow multi-track queueing #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfm
reviewed
Dec 13, 2023
smudge-track.el
Outdated
| @@ -303,12 +303,33 @@ Default to sortin tracks by number when listing the tracks from an album." | |||
| (defun smudge-track-add-to-queue () | |||
| "Add the track under the cursor to the queue." | |||
There was a problem hiding this comment.
Update docstring to reflect change in functionality.
smudge-track.el
Outdated
| (setq track-id (smudge-api-get-item-uri selected-track)) | ||
| (setq tracks (cons track-id tracks)) | ||
| (forward-line 1)) | ||
| ) |
There was a problem hiding this comment.
Avoid closing parens in new lines.
smudge-track.el
Outdated
Comment on lines
329
to
332
| (message "Added %d tracks to your queue." (length tracks)) ; Send the message here instead of in the callback | ||
| ; because the API call has to sequentially add each song which might take some time. | ||
| )) | ||
| ) |
There was a problem hiding this comment.
Avoid closing parens in new lines.
Maybe moving the comments to the line before, like you did in line 306-307?
smudge-api.el
Outdated
| (lambda (_) | ||
| (smudge-api-queue-add-tracks (cdr track-ids) callback))) | ||
| (when callback(funcall callback)) | ||
| )) |
There was a problem hiding this comment.
Avoid closing parens in new lines.
smudge-api.el
Outdated
| (car track-ids) | ||
| (lambda (_) | ||
| (smudge-api-queue-add-tracks (cdr track-ids) callback))) | ||
| (when callback(funcall callback)) |
There was a problem hiding this comment.
Add space between args.
Suggested change
| (when callback(funcall callback)) | |
| (when callback (funcall callback)) |
|
Hey, thanks for the feedback, I adapted your suggestions. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently found myself adding multiple tracks at the same time to the queue, with the current implementation I submitted in #93, this results in manually having to go over every track in the list.
With this PR, I'd like to extend the queue functionality to allow the user to add a selection of tracks inside the active region to the queue.
When no mark is set, it defaults to just adding the track under the cursor to the queue.