Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary margin from homepage #84

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix: remove unnecessary margin from homepage #84

merged 2 commits into from
Mar 19, 2024

Conversation

KunzRobert
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING and other relevant documents.

Description

I fixed a margin problem on the homepage

Screenshots:

before:

image

after:

image

@KunzRobert KunzRobert added UI/UX Design, color, scheme, and mockup related issues area: course Issue regarding the main package labels Mar 18, 2024
@KunzRobert KunzRobert requested a review from danieljancar March 18, 2024 12:27
@KunzRobert KunzRobert self-assigned this Mar 18, 2024
@KunzRobert KunzRobert linked an issue Mar 18, 2024 that may be closed by this pull request
Fix margin on homepage #82
Closed
7 tasks
danieljancar
danieljancar approved these changes Mar 19, 2024
View reviewed changes
Copy link
Owner

@danieljancar danieljancar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🔥

@danieljancar danieljancar merged commit 91490a9 into develop Mar 19, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

  • v1.0.0
  • v1.0.0

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

  • v1.0.0
  • v1.0.0

Your semantic-release bot 📦🚀

2 similar comments
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

  • v1.0.0
  • v1.0.0

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

  • v1.0.0
  • v1.0.0

Your semantic-release bot 📦🚀

@danieljancar danieljancar deleted the 82-fix-margin-on-homepage branch June 19, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljancar danieljancar danieljancar approved these changes

Assignees

@KunzRobert KunzRobert

Labels
area: course Issue regarding the main package released UI/UX Design, color, scheme, and mockup related issues
Projects
chorizo/kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix margin on homepage
2 participants
@KunzRobert @danieljancar