Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix answer with specified doc ids #2703

Merged
merged 10 commits into from
Nov 1, 2024
Merged

Fix answer with specified doc ids #2703

merged 10 commits into from
Nov 1, 2024

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Oct 6, 2024

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

@vercel Vercel
Copy link

vercel bot commented Oct 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 7:36pm

@Weves Weves force-pushed the fix-answer-with-specified-doc-ids branch from 05ad6c3 to 965ffe7 Compare October 8, 2024 02:39
@Weves Weves force-pushed the fix-answer-with-specified-doc-ids branch 2 times, most recently from 3b315a2 to 55b8740 Compare October 29, 2024 00:49
@Weves
Fix
5a0c6d0 
Fix

Refactor

more

more

fix

refactor

Fix circular imports

Refactor

Move tests around
@Weves Weves force-pushed the fix-answer-with-specified-doc-ids branch from 55b8740 to 5a0c6d0 Compare October 31, 2024 17:18
@Weves Weves marked this pull request as ready for review October 31, 2024 23:27
@pablodanswer pablodanswer added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit ecf4923 Nov 1, 2024
7 checks passed
@onimsha onimsha mentioned this pull request Nov 27, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablodanswer pablodanswer pablodanswer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Weves @pablodanswer