Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve indexing status display #278

Merged
merged 3 commits into from
Aug 12, 2023
Merged

Improve indexing status display #278

merged 3 commits into from
Aug 12, 2023

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Aug 12, 2023

Adds:

  • actual error message in UI for indexing failure
  • if a connector is disabled, stops indexing immediately (after the current batch of documents) to allow for deletion
  • adds num docs indexed for the current run + a speed
Screenshot 2023-08-12 at 2 14 10 PM

@vercel
Copy link

vercel bot commented Aug 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2023 9:19pm

@@ -132,8 +133,8 @@ def _get_user(
# categorize into groups of updates to try and batch them more efficiently
update_groups: dict[tuple[str, ...], list[str]] = {}
for document_id, allowed_users_lst in document_id_to_allowed_users.items():
# if document_id in document_ids_not_needing_update:
# continue
if document_id in document_ids_not_needing_update:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not have been commented out previously 😓


def upgrade() -> None:
op.create_index(
op.f("ix_index_attempt_latest_for_connector_credential_pair"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is ix?

backend/danswer/background/update.py Show resolved Hide resolved
@Weves Weves merged commit d5bb10b into main Aug 12, 2023
5 checks passed
@Weves Weves deleted the add-indexing-progress branch August 12, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants