Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using untyped dicts to represent quotes #310

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Stop using untyped dicts to represent quotes #310

merged 6 commits into from
Aug 17, 2023

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Aug 16, 2023

No description provided.

@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 9:47pm

Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit stuff only, ideally address

backend/danswer/direct_qa/on_startup.py Outdated Show resolved Hide resolved
backend/danswer/direct_qa/on_startup.py Outdated Show resolved Hide resolved
@Weves Weves merged commit f37ac76 into main Aug 17, 2023
5 checks passed
@Weves Weves deleted the quote-structure branch August 17, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants