Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 400 error when author of ticket is no longer an active user in … #3168

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

jwjordan
Copy link
Contributor

…a Zendesk account.

Description

In edge cases, there can be Zendesk tickets that have authors that no longer exist in Zendesk. This results in a userId of -1, which then throws a 400 error that is uncaught. I've updated the error handling and the specific cases where -1 is returned.

How Has This Been Tested?

Tested this locally and in a production environment connected to our Zendesk account. The problem ticket was properly processed.

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Nov 20, 2024

@jwjordan is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for your contribution!

@yuhongsun96 yuhongsun96 merged commit d9b87bb into danswer-ai:main Nov 23, 2024
4 of 9 checks passed
ahmadassaf pushed a commit to ahmadassaf/danswer that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants