Skip to content

Commit

Permalink
DAOS-16457 test: remove display_memory_info (#15031) (#15075)
Browse files Browse the repository at this point in the history
display_memory_info was added to debug an issue when starting the servers,
but resolved by #14295.
It is no longer needed and consumes too much log space and time.

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
  • Loading branch information
daltonbohning committed Sep 5, 2024
1 parent 3d9e2d0 commit 185ba8f
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions src/tests/ftest/util/server_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -464,14 +464,6 @@ def support_collect_log(self, **kwargs):
return run_remote(
self.log, self._hosts, cmd.with_exports, timeout=self.collect_log_timeout.value)

def display_memory_info(self):
"""Display server hosts memory info."""
self.log.debug("#" * 80)
self.log.debug("<SERVER> Collection debug memory info")
run_remote(self.log, self._hosts, "free -m && df -h --type=tmpfs")
run_remote(self.log, self._hosts, "ps -eo size,pid,user,command --sort -size | head -n 6")
self.log.debug("#" * 80)

def detect_format_ready(self, reformat=False):
"""Detect when all the daos_servers are ready for storage format.
Expand Down Expand Up @@ -664,14 +656,11 @@ def start(self):
self.prepare()

# Start the servers and wait for them to be ready for storage format
self.display_memory_info()
self.detect_format_ready()

# Collect storage and network information from the servers.
self.display_memory_info()
self.information.collect_storage_information()
self.information.collect_network_information()
self.display_memory_info()

# Format storage and wait for server to change ownership
self.log.info("<SERVER> Formatting hosts: <%s>", self.dmg.hostlist)
Expand Down Expand Up @@ -711,9 +700,6 @@ def stop(self):
# Make sure the mount directory belongs to non-root user
self.set_scm_mount_ownership()

# Collective memory usage after stop.
self.display_memory_info()

# Report any errors after all stop actions have been attempted
if messages:
raise ServerFailed("Failed to stop servers:\n {}".format("\n ".join(messages)))
Expand Down

0 comments on commit 185ba8f

Please sign in to comment.