Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-11283 test: Enhance network failure test with IO. #10133

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rpadma2
Copy link
Contributor

@rpadma2 rpadma2 commented Aug 29, 2022

Skip-test: true

Signed-off-by: rpadma2 ravindran.padmanabhan@intel.com

Skip-test: true

Signed-off-by: rpadma2 <ravindran.padmanabhan@intel.com>
@github-actions
Copy link

github-actions bot commented Aug 29, 2022

Bug-tracker data:
Ticket title is 'Physical durability test - network failure'
Status is 'Blocked'
https://daosio.atlassian.net/browse/DAOS-11283

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -112,8 +113,22 @@
self.log.info("hostname -i results = %s", results)

return {result["stdout"][0]: NodeSet(str(result["hosts"])) for result in results}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) trailing whitespace

@@ -112,8 +113,22 @@
self.log.info("hostname -i results = %s", results)

return {result["stdout"][0]: NodeSet(str(result["hosts"])) for result in results}

def bring_network_interface_down(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pylint-missing-function-docstring) Missing function or method docstring

@@ -112,8 +113,22 @@
self.log.info("hostname -i results = %s", results)

return {result["stdout"][0]: NodeSet(str(result["hosts"])) for result in results}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@daosbuild1
Copy link
Collaborator

Skip-test: true

Signed-off-by: rpadma2 <ravindran.padmanabhan@intel.com>
@daosbuild1 daosbuild1 dismissed their stale review September 26, 2022 22:58

Updated patch

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Skip-test: true

Signed-off-by: Padmanabhan <ravindran.padmanabhan@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Skip-tests: True

Signed-off-by: Padmanabhan <ravindran.padmanabhan@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10133/4/execution/node/1241/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants