DAOS-11218 control: Make some dmg pool commands synchronous #11600

mjmac · 2023-03-02T13:41:41Z

The following pool commands are now synchronous (i.e. wait
until rebuild has completed) by default:

dmg pool exclude
dmg pool drain
dmg pool extend
dmg pool reintegrate

If desired, the --async flag can be supplied to restore
the previous behavior where the command returns immediately
after the initial RPC completes.

Features: pool osa

Required-githooks: true

Signed-off-by: Michael MacDonald mjmac.macdonald@intel.com

github-actions · 2023-03-02T13:42:05Z

Bug-tracker data:
Ticket title is 'Improve pool reintegrate workflow'
Status is 'In Review'
Labels: 'usability'
https://daosio.atlassian.net/browse/DAOS-11218

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-03-03T16:13:27Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/1/execution/node/1250/log

daosbuild1 · 2023-03-03T21:20:32Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/1/execution/node/1297/log

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-03-04T10:15:27Z

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/2/execution/node/1031/log

daosbuild1 · 2023-03-06T14:46:26Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/3/execution/node/703/log

daosbuild1 · 2023-03-06T16:22:29Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/3/execution/node/719/log

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-03-08T20:34:56Z

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/4/execution/node/1031/log

daosbuild1 · 2023-03-09T12:02:11Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/4/execution/node/1254/log

daosbuild1 · 2023-03-09T12:34:24Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/4/execution/node/1301/log

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-03-10T03:24:07Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/5/execution/node/1297/log

daosbuild1 · 2023-03-10T04:32:26Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/5/execution/node/1250/log

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-03-18T04:22:08Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/6/execution/node/1274/log

daosbuild1 · 2023-03-18T04:24:59Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/6/execution/node/1189/log

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-03-30T07:07:08Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/7/execution/node/1274/log

daosbuild1 · 2023-03-30T07:26:33Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/7/execution/node/1227/log

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-04-18T09:34:16Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-11600/8/display/redirect

daosbuild1 · 2023-05-29T20:58:38Z

Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-11600/16/testReport/(root)/

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-06-08T01:34:05Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/17/execution/node/1283/log

daosbuild1 · 2023-06-08T01:48:09Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/17/execution/node/1256/log

tanabarr

looks like some good improvements

tanabarr · 2023-11-01T16:46:08Z

src/control/server/mgmt_svc.go

+
+// serialReqLoop is the main loop for processing serial requests.
+func (svc *mgmtSvc) serialReqLoop(parent context.Context) {
+


unnecessary newline

github-actions · 2024-08-12T16:54:27Z

Ticket title is 'Improve pool reintegrate workflow'
Status is 'In Review'
Labels: 'usability'
https://daosio.atlassian.net/browse/DAOS-11218

daosbuild1 · 2024-08-12T16:55:53Z

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/18/execution/node/372/log

daosbuild1 · 2024-08-12T16:57:02Z

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/18/execution/node/326/log

daosbuild1 · 2024-08-12T16:58:44Z

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/18/execution/node/357/log

daosbuild1 · 2024-08-12T16:59:06Z

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/18/execution/node/323/log

daosbuild1 · 2024-08-12T17:02:54Z

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/18/execution/node/299/log

daosbuild1 · 2024-08-12T17:05:01Z

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/18/execution/node/521/log

daosbuild1 · 2024-08-28T11:33:44Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/19/execution/node/1441/log

daosbuild1 · 2024-08-28T13:16:01Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/19/execution/node/1462/log

The following pool commands are now synchronous and will wait for the operation to complete by default: * dmg pool exclude * dmg pool drain * dmg pool extend * dmg pool reintegrate If desired, the --async flag can be supplied to restore the previous behavior where the command returns immediately after the initial RPC completes. Required-githooks: true Change-Id: I84b3cd212fcce30710cddfacddaa6951512c0b2a Signed-off-by: Michael MacDonald <mjmac.macdonald@intel.com>

daosbuild1 · 2024-11-09T17:00:48Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-11600/20/testReport/

daosbuild1 · 2024-11-11T03:21:13Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/20/execution/node/1435/log

daosbuild1 · 2024-11-11T08:09:57Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/20/execution/node/1481/log

Required-githooks: true Change-Id: I44a0dab01c800d68ac01fc565a0b9aa9749acc67 Signed-off-by: Michael MacDonald <mjmac@google.com>

daosbuild1 · 2024-11-11T14:45:35Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-11600/21/testReport/

daosbuild1 · 2024-11-11T21:46:39Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/21/execution/node/1491/log

daosbuild1 · 2024-11-11T22:25:55Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11600/21/execution/node/1528/log

tanabarr · 2024-11-12T11:42:07Z

I'm assuming this is going to require significant test code changes, is that right?

mjmac · 2024-11-12T17:01:41Z

I'm assuming this is going to require significant test code changes, is that right?

Not sure... I was hoping it would just work, but doesn't seem like it. I did make a small change to the daos_test helper to use the previous async behavior. I will probably need to either also do that in ftest or make changes to handle the synchronous behavior. I'd prefer that most test coverage use the sync path though, as that's the default.

mjmac requested a review from a team as a code owner March 2, 2023 13:41

daosbuild1 reviewed Mar 2, 2023

View reviewed changes

mjmac force-pushed the mjmac/DAOS-11218 branch from 05241a4 to c0c3dda Compare March 3, 2023 22:10

daosbuild1 reviewed Mar 3, 2023

View reviewed changes

mjmac force-pushed the mjmac/DAOS-11218 branch from c0c3dda to 15ce0d7 Compare March 8, 2023 14:10

daosbuild1 reviewed Mar 8, 2023

View reviewed changes

mjmac force-pushed the mjmac/DAOS-11218 branch from 15ce0d7 to 251ca17 Compare March 9, 2023 13:28

daosbuild1 reviewed Mar 9, 2023

View reviewed changes

mjmac force-pushed the mjmac/DAOS-11218 branch from 251ca17 to 7a08327 Compare March 17, 2023 13:09

daosbuild1 reviewed Mar 17, 2023

View reviewed changes

mjmac force-pushed the mjmac/DAOS-11218 branch from 7a08327 to 9985c11 Compare March 28, 2023 19:10

daosbuild1 reviewed Mar 28, 2023

View reviewed changes

mjmac force-pushed the mjmac/DAOS-11218 branch from 9985c11 to 6345c0b Compare April 17, 2023 21:23

daosbuild1 reviewed Apr 17, 2023

View reviewed changes

mjmac force-pushed the mjmac/DAOS-11218 branch from 777f967 to 1e6d760 Compare June 7, 2023 13:13

daosbuild1 reviewed Jun 7, 2023

View reviewed changes

tanabarr previously approved these changes Nov 1, 2023

View reviewed changes

mjmac marked this pull request as draft August 12, 2024 16:45

mjmac dismissed tanabarr’s stale review via 7b4a37b August 12, 2024 16:50

mjmac force-pushed the mjmac/DAOS-11218 branch from 1e6d760 to 7b4a37b Compare August 12, 2024 16:50

mjmac force-pushed the mjmac/DAOS-11218 branch from 7b4a37b to dfdddd4 Compare August 27, 2024 20:03

mjmac force-pushed the mjmac/DAOS-11218 branch from dfdddd4 to 207c19f Compare November 9, 2024 16:08

Adjust daos_test calls to be async

b1ad06c

Required-githooks: true Change-Id: I44a0dab01c800d68ac01fc565a0b9aa9749acc67 Signed-off-by: Michael MacDonald <mjmac@google.com>


		// serialReqLoop is the main loop for processing serial requests.
		func (svc *mgmtSvc) serialReqLoop(parent context.Context) {

DAOS-11218 control: Make some dmg pool commands synchronous #11600

Are you sure you want to change the base?

DAOS-11218 control: Make some dmg pool commands synchronous #11600

Conversation

mjmac commented Mar 2, 2023

github-actions bot commented Mar 2, 2023 • edited Loading

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Mar 3, 2023

daosbuild1 commented Mar 3, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Mar 4, 2023

daosbuild1 commented Mar 6, 2023

daosbuild1 commented Mar 6, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Mar 8, 2023

daosbuild1 commented Mar 9, 2023

daosbuild1 commented Mar 9, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Mar 10, 2023

daosbuild1 commented Mar 10, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Mar 18, 2023

daosbuild1 commented Mar 18, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Mar 30, 2023

daosbuild1 commented Mar 30, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Apr 18, 2023

daosbuild1 commented May 29, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Jun 8, 2023

daosbuild1 commented Jun 8, 2023

tanabarr left a comment

Choose a reason for hiding this comment

tanabarr Nov 1, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 12, 2024

daosbuild1 commented Aug 12, 2024

daosbuild1 commented Aug 12, 2024

daosbuild1 commented Aug 12, 2024

daosbuild1 commented Aug 12, 2024

daosbuild1 commented Aug 12, 2024

daosbuild1 commented Aug 12, 2024

daosbuild1 commented Aug 28, 2024

daosbuild1 commented Aug 28, 2024

daosbuild1 commented Nov 9, 2024

daosbuild1 commented Nov 11, 2024

daosbuild1 commented Nov 11, 2024

daosbuild1 commented Nov 11, 2024

daosbuild1 commented Nov 11, 2024

daosbuild1 commented Nov 11, 2024

tanabarr commented Nov 12, 2024

mjmac commented Nov 12, 2024

github-actions bot commented Mar 2, 2023 •

edited

Loading